Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal: 3.4.2 -> 3.5.2 #179406

Merged
merged 19 commits into from
Nov 15, 2022
Merged

gdal: 3.4.2 -> 3.5.2 #179406

merged 19 commits into from
Nov 15, 2022

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jun 28, 2022

Description of changes

https://github.com/OSGeo/gdal/blob/v3.5.1/NEWS.md

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

@jtojnar You "recently" touched mysql-workbench. Do you have a suggestion how to fix it?

$ nix-build -A mysql-workbench
error: attribute 'dev' missing

       at pkgs/development/libraries/gdal/default.nix:89:28:

           88|     "-DGEOTIFF_LIBRARY_RELEASE=${libgeotiff}/lib/libgeotiff${stdenv.hostPlatform.extensions.sharedLibrary}"
           89|     "-DMYSQL_INCLUDE_DIR=${libmysqlclient.dev}/include/mysql"
             |                            ^
           90|     "-DMYSQL_LIBRARY=${libmysqlclient}/lib/mysql/libmysqlclient${stdenv.hostPlatform.extensions.sharedLibrary}"

The relevant code is in pkgs/top-level/all-packages.nix:

mysql-workbench = callPackage ../applications/misc/mysql-workbench (let mysql = mysql57; in {
  gdal = gdal.override {
    libmysqlclient = mysql // {
      lib = { dev = mysql; }
    ;}
  ;};
  mysql = mysql;
  pcre = pcre-cpp;
  jre = jre8; # TODO: remove override https://github.com/NixOS/nixpkgs/pull/89731
});

@dotlambda dotlambda force-pushed the gdal-3.5.0.3 branch 2 times, most recently from c8d4e09 to 26ae88b Compare June 28, 2022 06:12
@jtojnar
Copy link
Member

jtojnar commented Jun 28, 2022

Continue using lib.getDev? And the override can be trimmed to:

gdal = gdal.override {
  libmysqlclient = mysql // {
    dev = mysql;
  };
};

or even

gdal = gdal.override {
  libmysqlclient = mysql;
};

since getDev will pull the dev output only when present.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 28, 2022
@ofborg ofborg bot requested a review from MarcWeber June 28, 2022 17:58
@dotlambda dotlambda marked this pull request as ready for review June 28, 2022 18:20
@Artturin
Copy link
Member

Artturin commented Jun 29, 2022

Result of nixpkgs-review pr 179406 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • python310Packages.basemap
  • python310Packages.descartes
  • python310Packages.worldengine
  • python39Packages.basemap
  • python39Packages.descartes
  • python39Packages.worldengine
  • worldengine-cli
20 packages failed to build:
  • apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
  • gplates
  • mapnik
  • perl532Packages.Tirex
  • perl534Packages.Tirex
  • python310Packages.asf-search
  • python310Packages.cartopy
  • python310Packages.fiona
  • python310Packages.geopandas
  • python310Packages.osmnx
  • python310Packages.rasterio
  • python310Packages.wktutils
  • python39Packages.asf-search
  • python39Packages.cartopy
  • python39Packages.fiona
  • python39Packages.geopandas
  • python39Packages.osmnx
  • python39Packages.rasterio
  • python39Packages.wktutils
  • t-rex
75 packages built:
  • brunsli
  • cloudcompare
  • cura
  • flatcam
  • gdal (python310Packages.gdal)
  • gdal_2
  • geos
  • gmt
  • gnudatalanguage
  • grass
  • haskellPackages.hgeos
  • lerc
  • libLAS
  • libgeotiff
  • librttopo
  • libspatialite
  • mapcache
  • mapproxy
  • mapserver
  • merkaartor
  • moonraker
  • openorienteering-mapper
  • osmscout-server
  • paraview
  • pdal
  • pdal_2_3
  • postgresql11Packages.postgis
  • postgresql12Packages.postgis
  • postgresql13Packages.postgis
  • postgresqlPackages.postgis (postgresql14Packages.postgis)
  • python310Packages.aplpy
  • python310Packages.flask-admin
  • python310Packages.geoalchemy2
  • python310Packages.imgaug
  • python310Packages.mask-rcnn
  • python310Packages.opensfm
  • python310Packages.owslib
  • python310Packages.preprocess-cancellation
  • python310Packages.pygeos
  • python310Packages.pygmt
  • python310Packages.pyosmium
  • python310Packages.pyproj
  • python310Packages.python-mapnik
  • python310Packages.shapely
  • python310Packages.spectral-cube
  • python310Packages.uranium
  • python39Packages.aplpy
  • python39Packages.flask-admin
  • python39Packages.gdal
  • python39Packages.geoalchemy2
  • python39Packages.imgaug
  • python39Packages.mask-rcnn
  • python39Packages.opensfm
  • python39Packages.owslib
  • python39Packages.preprocess-cancellation
  • python39Packages.pygeos
  • python39Packages.pygmt
  • python39Packages.pyosmium
  • python39Packages.pyproj
  • python39Packages.python-mapnik
  • python39Packages.shapely
  • python39Packages.spectral-cube
  • python39Packages.uranium
  • pytrainer
  • qgis
  • qgis-ltr
  • qlandkartegt
  • qmapshack
  • readosm
  • saga
  • spatialite_tools
  • sumo
  • udig
  • valhalla
  • xastir
error: builder for '/nix/store/i8r2pi11sgmzlax272pwnzlzkpqjrsl0-gplates-2.3.0.drv' failed with exit code 1;
       last 10 log lines:
       >   If "boost_python310" provides a separate development package or SDK, be
       >   sure it has been installed.
       > Call Stack (most recent call first):
       >   /nix/store/5qvzph936rzbmzn63v81d6a7qdjcp67r-boost-1.75.0-dev/lib/cmake/Boost-1.75.0/BoostConfig.cmake:258 (boost_find_component)
       >   /nix/store/glq7agqbd4fg6lmc2pwh75malh1bvdbw-cmake-3.22.3/share/cmake-3.22/Modules/FindBoost.cmake:594 (find_package)
       >   src/CMakeLists.txt:221 (find_package)
       >
       >
       > -- Configuring incomplete, errors occurred!
       > See also "/build/gplates_2.3.0_src/build/CMakeFiles/CMakeOutput.log".
       For full logs, run 'nix log /nix/store/i8r2pi11sgmzlax272pwnzlzkpqjrsl0-gplates-2.3.0.drv'.
error: builder for '/nix/store/dbv2nfqamv084ydzjnkjrnya76vadai0-t-rex-0.14.3.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
       >   cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
       >   cargo:rustc-cfg=gdal_sys_3_5_0
       >
       >   --- stderr
       >   thread 'main' panicked at 'No pre-built bindings available for GDAL version 3.5. Use `--features bindgen` to generate your own bindings.', /build/t-rex-0.14.3-vendor.tar.gz/gdal-sys/build.rs:220:17
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run 'nix log /nix/store/dbv2nfqamv084ydzjnkjrnya76vadai0-t-rex-0.14.3.drv'.
error: builder for '/nix/store/xbbs7hscf28hn6khlh8h5hl19m6bc4m8-python3.9-rasterio-1.2.10.drv' failed with exit code 1;
       last 10 log lines:
       >   ╰─> See above for output.
       >
       >   note: This error originates from a subprocess, and is likely not a problem with pip.
       >   full command: /nix/store/as5aamjfk9da5napyp5hpn6hha6f7cmp-python3-3.9.13/bin/python3.9 /nix/store/knd4zvcmqys1mra2wm1vhmlkln8ky3nh-python3.9-pip-22.1.2/lib/python3.9/site-packages/pip/_vendor/pep517/in_
process/_in_process.py build_wheel /build/tmpl_mz7e_w
       >   cwd: /build/source
       >   Building wheel for rasterio (pyproject.toml) ... error
       >   ERROR: Failed building wheel for rasterio
       > Failed to build rasterio
       > ERROR: Failed to build one or more wheels
       >
       For full logs, run 'nix log /nix/store/xbbs7hscf28hn6khlh8h5hl19m6bc4m8-python3.9-rasterio-1.2.10.drv'.
error: builder for '/nix/store/nf8fncy3qx9h7vz866qyg9z350mhaxjz-python3.10-rasterio-1.2.10.drv' failed with exit code 1;
       last 10 log lines:
       >   ╰─> See above for output.
       >
       >   note: This error originates from a subprocess, and is likely not a problem with pip.
       >   full command: /nix/store/i6svmmq24wl4i10dx0m8blrpl3m3fq4b-python3-3.10.5/bin/python3.10 /nix/store/bwlp4fdf5gldsq5iw48i419c1dp23yca-python3.10-pip-22.1.2/lib/python3.10/site-packages/pip/_vendor/pep517/
in_process/_in_process.py build_wheel /build/tmp_poo_7ob
       >   cwd: /build/source                                                                                                                                                                                 [26/92]
       >   Building wheel for rasterio (pyproject.toml) ... error
       >   ERROR: Failed building wheel for rasterio
       > Failed to build rasterio
       > ERROR: Failed to build one or more wheels       >       For full logs, run 'nix log /nix/store/nf8fncy3qx9h7vz866qyg9z350mhaxjz-python3.10-rasterio-1.2.10.drv'.
error: builder for '/nix/store/f4pdwwmp49scy14kzb0dzdj3gfkh2q4a-python3.9-fiona-1.8.21.drv' failed with exit code 139;
       last 10 log lines:
       >   File "/nix/store/0h5iqclvqnk6mbgynqxns3vrgi312a66-python3.9-pytest-7.1.1/lib/python3.9/site-packages/_pytest/main.py", line 315 in pytest_cmdline_main       >   File "/nix/store/qv9q9y2d778vbxkz4m4clinr1w9rp2rk-python3.9-pluggy-1.0.0/lib/python3.9/site-packages/pluggy/_callers.py", line 39 in _multicall       >   File "/nix/store/qv9q9y2d778vbxkz4m4clinr1w9rp2rk-python3.9-pluggy-1.0.0/lib/python3.9/site-packages/pluggy/_manager.py", line 80 in _hookexec       >   File "/nix/store/qv9q9y2d778vbxkz4m4clinr1w9rp2rk-python3.9-pluggy-1.0.0/lib/python3.9/site-packages/pluggy/_hooks.py", line 265 in __call__       >   File "/nix/store/0h5iqclvqnk6mbgynqxns3vrgi312a66-python3.9-pytest-7.1.1/lib/python3.9/site-packages/_pytest/config/__init__.py", line 164 in main       >   File "/nix/store/0h5iqclvqnk6mbgynqxns3vrgi312a66-python3.9-pytest-7.1.1/lib/python3.9/site-packages/_pytest/config/__init__.py", line 187 in console_main       >   File "/nix/store/0h5iqclvqnk6mbgynqxns3vrgi312a66-python3.9-pytest-7.1.1/lib/python3.9/site-packages/pytest/__main__.py", line 5 in <module>
       >   File "/nix/store/as5aamjfk9da5napyp5hpn6hha6f7cmp-python3-3.9.13/lib/python3.9/runpy.py", line 87 in _run_code
       >   File "/nix/store/as5aamjfk9da5napyp5hpn6hha6f7cmp-python3-3.9.13/lib/python3.9/runpy.py", line 197 in _run_module_as_main
       > /nix/store/c8np98ks7hkax20dkirjbhmqw6kbg3w9-pytest-check-hook/nix-support/setup-hook: line 53:   483 Segmentation fault      (core dumped) /nix/store/as5aamjfk9da5napyp5hpn6hha6f7cmp-python3-3.9.13/bin/py
thon3.9 -m pytest -k "not http and not https and not wheel"
       For full logs, run 'nix log /nix/store/f4pdwwmp49scy14kzb0dzdj3gfkh2q4a-python3.9-fiona-1.8.21.drv'.
error: 1 dependencies of derivation '/nix/store/xbihp5lflmghqg9gxlvanw8v71hxdgpn-python3.9-cartopy-0.20.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ip20gmd33ppsg12ciwvh256ayjxq5pq7-python3.9-geopandas-0.10.2.drv' failed to build
error: 2 dependencies of derivation '/nix/store/py472hlp0cjj30nrbk894iswg44jinqx-python3.9-osmnx-1.2.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/h598ywv1w0ndlg89a422lfkskg5v2ldb-python3.9-wktutils-1.1.5.drv' failed to build
error: 1 dependencies of derivation '/nix/store/a2g712x3b8wx3xxyx2fxyl3x2ipxsh77-python3.9-asf-search-3.2.2.drv' failed to build
error: builder for '/nix/store/vhbm3wg13jfmlvfjfayy8vxz68in3i6v-python3.10-fiona-1.8.21.drv' failed with exit code 139;
       last 10 log lines:
       >   File "/nix/store/2jkfr4ylndcvk0ac9hr3lq7xk28az6xj-python3.10-pluggy-1.0.0/lib/python3.10/site-packages/pluggy/_manager.py", line 80 in _hookexec
       >   File "/nix/store/2jkfr4ylndcvk0ac9hr3lq7xk28az6xj-python3.10-pluggy-1.0.0/lib/python3.10/site-packages/pluggy/_hooks.py", line 265 in __call__
       >   File "/nix/store/b2jin0yhd1jc8vh8iq6wvrk1jm3g399d-python3.10-pytest-7.1.1/lib/python3.10/site-packages/_pytest/config/__init__.py", line 164 in main
       >   File "/nix/store/b2jin0yhd1jc8vh8iq6wvrk1jm3g399d-python3.10-pytest-7.1.1/lib/python3.10/site-packages/_pytest/config/__init__.py", line 187 in console_main
       >   File "/nix/store/b2jin0yhd1jc8vh8iq6wvrk1jm3g399d-python3.10-pytest-7.1.1/lib/python3.10/site-packages/pytest/__main__.py", line 5 in <module>
       >   File "/nix/store/i6svmmq24wl4i10dx0m8blrpl3m3fq4b-python3-3.10.5/lib/python3.10/runpy.py", line 86 in _run_code
       >   File "/nix/store/i6svmmq24wl4i10dx0m8blrpl3m3fq4b-python3-3.10.5/lib/python3.10/runpy.py", line 196 in _run_module_as_main
       >
       > Extension modules: fiona._err, fiona._geometry, fiona._shim, fiona._env, fiona.schema, fiona.ogrext, fiona._crs, fiona._transform, _brotli, _cffi_backend (total: 10)
       > /nix/store/wq7dz4spsh6lzmrm452jfppx626li4rs-pytest-check-hook/nix-support/setup-hook: line 53:   483 Segmentation fault      (core dumped) /nix/store/i6svmmq24wl4i10dx0m8blrpl3m3fq4b-python3-3.10.5/bin/py
thon3.10 -m pytest -k "not http and not https and not wheel"
       For full logs, run 'nix log /nix/store/vhbm3wg13jfmlvfjfayy8vxz68in3i6v-python3.10-fiona-1.8.21.drv'.
error: 1 dependencies of derivation '/nix/store/b5mkkh2r6b0jsg5bib3222wb38w8z28z-python3.10-cartopy-0.20.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/8yfr3l2vndbf9i0msr6s6j3bqdjqd35n-python3.10-geopandas-0.10.2.drv' failed to build
error: 2 dependencies of derivation '/nix/store/gsmx7pwxrj8jcv3l0yxhz79hd4zqhp6w-python3.10-osmnx-1.2.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/dyckv11vg530kd1i8d3xpj3qm7wqjjaj-python3.10-wktutils-1.1.5.drv' failed to build
error: 1 dependencies of derivation '/nix/store/wij7xi79h9hpf77ikbpkriqq1jr69n68-python3.10-asf-search-3.2.2.drv' failed to build
error: 16 dependencies of derivation '/nix/store/y7xc0pid2mhfvwzww4hk3fbfrhpscszc-env.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vhbqm5b847rqx7fa1g7k76zzdd9rbw6n-review-shell.drv' failed to build

@dotlambda
Copy link
Member Author

The rasterio failure is probably due to OSGeo/gdal#6004.
The fiona failure is tracked upstream: Toblerity/Fiona#1099.

@dotlambda dotlambda marked this pull request as ready for review July 7, 2022 07:25
@dotlambda dotlambda changed the title gdal: 3.4.2 -> 3.5.0.3 gdal: 3.4.2 -> 3.5.1 Jul 7, 2022
@ofborg ofborg bot requested a review from knedlsepp July 7, 2022 07:32
@dotlambda dotlambda marked this pull request as draft July 9, 2022 00:31
@willcohen
Copy link
Contributor

Note that there is now a PR for a version bump of GEOS at #181988.

@willcohen
Copy link
Contributor

Result of nixpkgs-review pr 179406 run on x86_64-darwin 1

18 packages marked as broken and skipped:
  • flatcam
  • gnudatalanguage
  • gplates
  • merkaartor
  • openorienteering-mapper
  • pdal
  • pdal_2_3
  • python310Packages.basemap
  • python310Packages.descartes
  • python310Packages.mask-rcnn
  • python310Packages.opensfm
  • python310Packages.pygmt
  • python39Packages.basemap
  • python39Packages.descartes
  • python39Packages.mask-rcnn
  • python39Packages.opensfm
  • python39Packages.pygmt
  • saga
35 packages failed to build:
  • gdal (python310Packages.gdal)
  • gmt
  • grass
  • libLAS
  • mapcache
  • mapnik
  • mapproxy
  • mapserver
  • perl532Packages.Tirex
  • perl534Packages.Tirex
  • postgresql11Packages.postgis
  • postgresql12Packages.postgis
  • postgresql13Packages.postgis
  • postgresqlPackages.postgis (postgresql14Packages.postgis)
  • python310Packages.asf-search
  • python310Packages.cartopy
  • python310Packages.fiona
  • python310Packages.geopandas
  • python310Packages.osmnx
  • python310Packages.python-mapnik
  • python310Packages.rasterio
  • python310Packages.wktutils
  • worldengine-cli (python310Packages.worldengine)
  • python39Packages.asf-search
  • python39Packages.cartopy
  • python39Packages.fiona
  • python39Packages.gdal
  • python39Packages.geopandas
  • python39Packages.osmnx
  • python39Packages.python-mapnik
  • python39Packages.rasterio
  • python39Packages.wktutils
  • python39Packages.worldengine
  • t-rex
  • udig
24 packages built:
  • gdal_2
  • haskellPackages.hgeos
  • libgeotiff
  • libspatialite
  • python310Packages.aplpy
  • python310Packages.flask-admin
  • python310Packages.geoalchemy2
  • python310Packages.owslib
  • python310Packages.preprocess-cancellation
  • python310Packages.pygeos
  • python310Packages.pyosmium
  • python310Packages.pyproj
  • python310Packages.shapely
  • python310Packages.spectral-cube
  • python39Packages.aplpy
  • python39Packages.flask-admin
  • python39Packages.geoalchemy2
  • python39Packages.owslib
  • python39Packages.preprocess-cancellation
  • python39Packages.pygeos
  • python39Packages.pyosmium
  • python39Packages.pyproj
  • python39Packages.shapely
  • python39Packages.spectral-cube

@willcohen
Copy link
Contributor

The GEOS bump to 3.11 has merged, so the GEOS commit here can be removed!

@sikmir
Copy link
Member

sikmir commented Sep 18, 2022

GDAL 3.5.2 is out.

@dotlambda dotlambda mentioned this pull request Nov 9, 2022
13 tasks
@ofborg ofborg bot requested a review from lsix November 9, 2022 18:30
@risicle
Copy link
Contributor

risicle commented Nov 10, 2022

basemap now needs its requirements adjusted to cope with the new pyproj

@risicle
Copy link
Contributor

risicle commented Nov 10, 2022

@ofborg build openorienteering-mapper

I was going to merge this before you pushed the proj change ;)

@risicle
Copy link
Contributor

risicle commented Nov 10, 2022

@ofborg build qmapshack

@dotlambda
Copy link
Member Author

I was going to merge this before you pushed the proj change ;)

Should I remove it again?

@dotlambda
Copy link
Member Author

dotlambda commented Nov 10, 2022

Definitely recognize that mapnik/box2d.hpp error though.

Should be an easy fix: mapnik/mapnik@f13848e

This fixes the problem but the missing dependencies mentioned in #179406 (comment) are still a problem.
I think I'm done fixing things here and will leave perlPackages.Tirex and t-rex to people who care about those pieces of software.

@risicle
Copy link
Contributor

risicle commented Nov 10, 2022

Does

Should we add boost, icu, and harfbuzz to mapnik's propagatedBuildInputs?

not help with that?

@dotlambda
Copy link
Member Author

Does

Should we add boost, icu, and harfbuzz to mapnik's propagatedBuildInputs?

not help with that?

No, we'd need to add mapnik's other inputs as well.

@risicle
Copy link
Contributor

risicle commented Nov 10, 2022

Hmm, and we're still ignoring the tests segfaulting on aarch64-linux

Appears to happen @

platform linux -- Python 3.10.8, pytest-7.1.3, pluggy-1.0.0 -- /nix/store/z9namwh6673vbzkfbhqdf05ypbp2sil1-python3-3.10.8/bin/python
cachedir: .pytest_cache
rootdir: /build/source/autotest, configfile: pytest.ini
plugins: env-0.6.2
collected 4 items                                                                                                                                                                                                                                                                                                                         

gcore/virtualmem.py::test_virtualmem_1 [New Thread 0x7fcf48f120 (LWP 29586)]

Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x0000007fd7282c0c in SHORT_copyswap () from /nix/store/pipvvqls04a54fz7wvqwlyy44pfhlw47-python3.10-numpy-1.23.3/lib/python3.10/site-packages/numpy/core/_multiarray_umath.cpython-310-aarch64-linux-gnu.so

or, without gdb getting in the way:

platform linux -- Python 3.10.8, pytest-7.1.3, pluggy-1.0.0 -- /nix/store/z9namwh6673vbzkfbhqdf05ypbp2sil1-python3-3.10.8/bin/python
cachedir: .pytest_cache
rootdir: /build/source/autotest, configfile: pytest.ini
plugins: env-0.6.2
collected 4 items                                                                                                                                                                                                                                                                                                                         

gcore/virtualmem.py::test_virtualmem_1 PASSED                                                                                                                                                                                                                                                                                       [ 25%]
gcore/virtualmem.py::test_virtualmem_2 Fatal Python error: Segmentation fault

Current thread 0x0000007fb690e020 (most recent call first):
  File "/build/source/autotest/gcore/virtualmem.py", line 111 in test_virtualmem_2

https://github.com/OSGeo/gdal/blob/049a667e2c15af7b05cbeaffed873881e6449256/autotest/gcore/virtualmem.py#L111

The actual (optional) dependency is http://www.kealib.org/.
@ofborg ofborg bot requested a review from mweinelt November 11, 2022 05:44
@risicle
Copy link
Contributor

risicle commented Nov 11, 2022

@ofborg build gdal

Just checking if my aarch64 machine is alone in getting the segfault.

@risicle
Copy link
Contributor

risicle commented Nov 11, 2022

Looks like I might be alone and perhaps we should ignore that. Still, makes me a little suspicious.

@dotlambda
Copy link
Member Author

Should we just merge and see what happens? We can always revert.

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we'll have to sort out anything remaining in ZHF

@mweinelt mweinelt merged commit af68e9c into NixOS:master Nov 15, 2022
@dotlambda dotlambda deleted the gdal-3.5.0.3 branch November 15, 2022 22:42
@ajs124
Copy link
Member

ajs124 commented Nov 15, 2022

either this or #200930 needs to be reverted/fixed, because currently it breaks eval with:
nixpkgs/pkgs/applications/science/misc/gplates/default.nix:1:1 called with unexpected argument 'python3'

edit: this does a lot more stuff, didn't really check the diff before commenting. so maybe just revert 8a236e2

"XMLPARSER=libxml2"
];

disabled = isPyPy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we place disabled near the top.

@dotlambda dotlambda mentioned this pull request Aug 7, 2023
12 tasks

nativeBuildInputs = [ autoreconfHook pkg-config unzip ];
cmakeFlags = [
"-DGDAL_USE_INTERNAL_LIBS=OFF"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to disable internal libs? To avoid vendoring? Could this be the reason LERC compression is currently unavailable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid vendoring?

This. It's hard enough to stay on top of all the libs that need security updates in nixpkgs without libraries hiding their own versions all over the place (which they frequently neglect for years)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.